feat: [FC-0070] add events and style for rendering Split xblock in chromeless template #35813
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @ihor-romaniuk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
ihor-romaniuk
force-pushed
the
romaniuk/children-container-for-rendering-split-test
branch
from
2f23ccb to
c054eb1
Compare
ihor-romaniuk
force-pushed
the
romaniuk/children-container-for-rendering-split-test
branch
2 times, most recently
from
01329d3 to
401ef42
Compare
…romeless template
ihor-romaniuk
force-pushed
the
romaniuk/children-container-for-rendering-split-test
branch
from
401ef42 to
24453ab
Compare
ihor-romaniuk
requested review from
PKulkoRaccoonGang,
arbrandes and
bradenmacdonald
| display: inline-flex; | ||
| align-items: center; | ||
| gap: 0.6rem; | ||
| padding: 0.3rem 1rem; |
There was a problem hiding this comment.
[question]: We don't use rems in this file. Should we be consistent or do we want to use rems everywhere?
There was a problem hiding this comment.
Replaced with $baseline, thanks
| } | ||
|
|
||
| .paste-component { | ||
| margin: 2.4rem 1rem 0; |
There was a problem hiding this comment.
[question]: You use $baseline for indentation, should we do this wherever possible?
|
Why are there so many changes in this PR related to the "Add New Component" UI? I thought that the MFE is providing that, and I don't like the idea of continuing to use the legacy UI for that. In fact (please correct me if I'm wrong), this seems to be doing something even worse - duplicating the new MFE "Add New Component" UI in the code of the old legacy UI. |
I appreciate you pointing out this issue. It’s an important topic, and I share the concern about avoiding duplication and improving the long-term approach to rendering xBlocks. This pull request includes many style adjustments to align the “Add New Component” block with the MFE styles. Since the Split_test xBlocks renders this block within an internal container, it was decided to visually adapt it within this scope of work, as a complete refactor would take significantly more time. I fully agree that rendering an iframe within the MFE is not an ideal solution. However, this approach was chosen because the previous implementation had performance issues on the page. Unfortunately, we do not yet have a unified approach or a common mechanism for rendering xBlocks. Once we establish a standardized way to display xBlocks in React, we will be able to completely eliminate the use of iframes. |
I see. I would have preferred that we don't spend time adapting the look of the legacy UI, but it's not my decision. |
Description
This feature introduces functionalities to improve XBlock interactions within iframes:
split_test.mov
Related Pull Requests
Testing instructions